Skip to content

Conversation

ZReC
Copy link
Contributor

@ZReC ZReC commented Mar 24, 2017

@qaisjp
Copy link
Contributor

qaisjp commented Mar 24, 2017

We try not to merge changes like these without understanding what the change does. Can you explain what the boolean represents? And thanks for the PR :)

@sbx320
Copy link
Member

sbx320 commented Mar 24, 2017

The flag overrides the check whether the rectangle to draw is within the rectangle with the vertices (1000000.0, 1000000.0) and (-1000000.0, -1000000.0).

@ZReC
Copy link
Contributor Author

ZReC commented Mar 24, 2017

So, this boolean is used in the original game executable to draw all the areas revealed in the menu map. Similarly works with the mini map, and not, as might be expected, does not yield poor performance with many charged areas.
Test it.

@jushar jushar merged commit 8203cb9 into multitheftauto:master Mar 24, 2017
@qaisjp
Copy link
Contributor

qaisjp commented Mar 24, 2017

Thanks again for the pull request :)

@qaisjp qaisjp added the bug Something isn't working label May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants